Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Avoid adding semicolon after a statement #8488

Merged
merged 2 commits into from
Jan 24, 2025
Merged

[C++] Avoid adding semicolon after a statement #8488

merged 2 commits into from
Jan 24, 2025
+31 −30

Conversation

tzik
Copy link
Contributor

@tzik tzik commented Jan 17, 2025

On the code generation for C++ object based API (--gen-object-api), existing code puts a semicolon after a else-statement, and that causes a compiler warning under -Wextra-semi-stmt on clang.

@github-actions github-actions bot added c++ codegen Involving generating code from schema labels Jan 17, 2025
dbaileychess
dbaileychess previously approved these changes Jan 22, 2025
View reviewed changes
@dbaileychess
Copy link
Collaborator

Looks like there is one missing file to update, check here

@tzik
Copy link
Contributor Author

tzik commented Jan 23, 2025

Looks like there is one missing file to update, check here

Thanks. Updated the CL to include that part.

@tzik tzik requested a review from dbaileychess January 23, 2025 03:46
@dbaileychess dbaileychess merged commit 9f94cee into google:master Jan 24, 2025
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbaileychess dbaileychess dbaileychess approved these changes

Assignees
No one assigned
Labels
c++ codegen Involving generating code from schema
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tzik @dbaileychess